linux-kernel - Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d02d2488-5e8e-8586-486f-ad5f01a60a02@infradead.org>
Date:   Tue, 6 Feb 2018 10:09:45 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ulf Magnusson <ulfalizer@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        paul.burton@...s.com
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        tfiga@...omium.org, Marek Szyprowski <m.szyprowski@...sung.com>,
        Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>,
        Linus Walleij <linus.walleij@...aro.org>, vgupta@...opsys.com,
        mgorman@...hsingularity.net, hch@....de, mina86@...a86.com,
        robh@...nel.org, sboyd@...eaurora.org, paulus@...abs.org,
        will.deacon@....com, Tony Lindgren <tony@...mide.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep.

On 02/04/2018 05:58 PM, Ulf Magnusson wrote:
> On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@...il.com> wrote:
>> The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3
>> driver").
>>
>> Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
>> ---
>>  drivers/auxdisplay/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 2c2ed9cf8796..3cba78d36eec 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -137,7 +137,7 @@ config CFAG12864B_RATE
>>  config IMG_ASCII_LCD
>>         tristate "Imagination Technologies ASCII LCD Display"
>>         depends on HAS_IOMEM
>> -       default y if MIPS_MALTA || MIPS_SEAD3
>> +       default y if MIPS_MALTA
>>         select SYSCON
>>         help
>>           Enable this to support the simple ASCII LCD displays found on
>> --
>> 2.14.1
>>
> 
> The SYSCON symbol selected here is also globally undefined. Maybe
> MFD_SYSCON was intended.

Yes.

from 2018-JAN-18, Corentin Labbe:
https://marc.info/?l=linux-kernel&m=151630656607526&w=2

-- 
~Randy