linux-kernel - Re: [PATCH] bluetooth: hci_ath: Replace mdelay with msleep in ath_wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <133171D5-E5F0-486D-869F-8066EB8ECE59@holtmann.org>
Date:   Wed, 7 Feb 2018 09:55:48 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bluetooth: hci_ath: Replace mdelay with msleep in
 ath_wakeup_ar3k

Hi Jia-Ju,

> ath_wakeup_ar3k() is never called from atomic context.
> 
> It is only called by ath_hci_uart_work() that is only called in 
> ath_open() via INIT_WORK().
> All of the above functions do not enter atomic context along the way.
> 
> Despite never getting called from atomic context, ath_wakeup_ar3k() calls
> mdelay() for busy wait.
> That is not necessary and can be replaced with msleep to avoid busy wait.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
> drivers/bluetooth/hci_ath.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel