linux-kernel - Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <FBF6DCBB-B0F5-446B-8FD1-106E2538A9C1@linaro.org>
Date:   Wed, 7 Feb 2018 10:45:14 +0100
From:   Paolo Valente <paolo.valente@...aro.org>
To:     Mike Galbraith <efault@....de>
Cc:     Oleksandr Natalenko <oleksandr@...alenko.name>,
        Jens Axboe <axboe@...nel.dk>,
        linux-block <linux-block@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        'Paolo Valente' via bfq-iosched 
        <bfq-iosched@...glegroups.com>,
        Alban Browaeys <alban.browaeys@...il.com>,
        Ming Lei <ming.lei@...hat.com>, Ivan Kozik <ivan@...ios.org>,
        SERENA ZIVIANI <169364@...denti.unimore.it>,
        Serena Ziviani <ziviani.serena@...il.com>,
        Holger Hoffstätte <holger@...lied-asynchrony.com>
Subject: Re: [PATCH BUGFIX 1/1] block, bfq: add requeue-request hook



> Il giorno 07 feb 2018, alle ore 10:23, Mike Galbraith <efault@....de> ha scritto:
> 
> On Wed, 2018-02-07 at 10:08 +0100, Paolo Valente wrote:
>> 
>> The first piece of information I need is whether this failure happens
>> even without "BFQ hierarchical scheduling support".
> 
> I presume you mean BFQ_GROUP_IOSCHED, which I do not have enabled.
> 

Great (so to speak), this saves us one step.

So, here's my next request for help: please apply the attached patch (compressed to preserve it from my email client) and retry. It adds several anomaly checks. I hope I have not added any false-positive check.

Thanks,
Paolo


Download attachment "0001-block-bfq-instrument-requeue-and-finish-request.patch.zip" of type "application/zip" (1500 bytes)



> 	-Mike