linux-kernel - Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180207094017.5a130e6a@gandalf.local.home>
Date:   Wed, 7 Feb 2018 09:40:17 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zamir SUN <sztsian@...il.com>
Cc:     Vladislav Valtchev <vladislav.valtchev@...il.com>,
        johannes.berg@...el.com, johannes@...solutions.net,
        linux-kernel@...r.kernel.org, zsun@...hat.com
Subject: Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

On Wed, 7 Feb 2018 22:01:46 +0800
Zamir SUN <sztsian@...il.com> wrote:


> Thanks for the heads-up! I did not see that before.
> 
> While just a note for this, in Fedora 27:
> 
> $ if command -v swig; then echo 1; else echo 0; fi
> /usr/bin/swig
> 1
> 
> Actually this test has the same problem as of `which swig` - When swig
> exists, the var SWIG_DEFINED will not be 1 (as shown above).
> 
> I see Vladislav is already on this thread. I hope this can be fixed
> before merging the patch set.
>

After doing some more testing, I'm going to push out the changes today.
Would you be able to add patches on top of the changes? We are doing a
restructuring of the directory such that it can grow more.

I'll be backporting these fixes to 2.6 and 2.7 as well.

Thanks!

-- Steve