[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ca3062ba-7f87-dbf2-a50f-9d9bdb421159@gmail.com>
Date: Wed, 7 Feb 2018 23:09:46 +0800
From: Zamir SUN <sztsian@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Vladislav Valtchev <vladislav.valtchev@...il.com>,
johannes.berg@...el.com, johannes@...solutions.net,
linux-kernel@...r.kernel.org, zsun@...hat.com
Subject: Re: [PATCH 1/2] trace-cmd: Fix the detection for swig
On 02/07/2018 10:40 PM, Steven Rostedt wrote:
> On Wed, 7 Feb 2018 22:01:46 +0800
> Zamir SUN <sztsian@...il.com> wrote:
>
>
>> Thanks for the heads-up! I did not see that before.
>>
>> While just a note for this, in Fedora 27:
>>
>> $ if command -v swig; then echo 1; else echo 0; fi
>> /usr/bin/swig
>> 1
>>
>> Actually this test has the same problem as of `which swig` - When swig
>> exists, the var SWIG_DEFINED will not be 1 (as shown above).
>>
>> I see Vladislav is already on this thread. I hope this can be fixed
>> before merging the patch set.
>>
>
> After doing some more testing, I'm going to push out the changes today.
> Would you be able to add patches on top of the changes? We are doing a
> restructuring of the directory such that it can grow more.
>
> I'll be backporting these fixes to 2.6 and 2.7 as well.
>
Sure, I will rebase after Vladislav's patch set is merged.
Thanks!
--
Zamir SUN
Fedora user
GPG : 1D86 6D4A 49CE 4BBD 72CF FCF5 D856 6E11 F2A0 525E
Powered by blists - more mailing lists