linux-kernel - Re: [PATCH v4 2/2] dt-bindings/interrupt-controller: pdc: descibe PDC device binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180207164324.GP9465@builder>
Date:   Wed, 7 Feb 2018 08:43:24 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Lina Iyer <ilina@...eaurora.org>
Cc:     tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        rnayak@...eaurora.org, asathyak@...eaurora.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings/interrupt-controller: pdc: descibe
 PDC device binding

On Wed 07 Feb 07:49 PST 2018, Lina Iyer wrote:
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
[..]
> +Example:
[..]
> +	wake-device {
> +		[...]
> +		interrupt-controller = <&pdc>;

Sorry for not seeing this earlier, but this should be:

		interrupt-parent = <&pdc>;

Or as it's not unlikely that clients might use a mix of pdc and non-pdc
interrupts the example could use the form:

		interrupts-extended = <&pdc 2 IRQ_TYPE_LEVEL_HIGH>;

> +		interrupt = <2 IRQ_TYPE_LEVEL_HIGH>;
> +	};

Regards,
Bjorn