linux-kernel - Re: [PATCH] irqchip: Use %px to print pointer value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba5fb474-4e45-8d8d-ee5d-9f1a211090e3@arm.com>
Date:   Fri, 9 Feb 2018 08:51:33 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Jaedon Shin <jaedon.shin@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Kevin Cernekee <cernekee@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] irqchip: Use %px to print pointer value

On 09/02/18 02:10, Jaedon Shin wrote:
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
> pointers printed with %p are hashed. Use %px instead of %p to print
> pointer value.
> 
> Signed-off-by: Jaedon Shin <jaedon.shin@...il.com>
> ---
>  drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>  drivers/irqchip/irq-bcm7120-l2.c | 2 +-
>  drivers/irqchip/irq-brcmstb-l2.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
> index 55cfb986225b..f604c1d89b3b 100644
> --- a/drivers/irqchip/irq-bcm7038-l1.c
> +++ b/drivers/irqchip/irq-bcm7038-l1.c
> @@ -339,7 +339,7 @@ int __init bcm7038_l1_of_init(struct device_node *dn,
>  		goto out_unmap;
>  	}
>  
> -	pr_info("registered BCM7038 L1 intc (mem: 0x%p, IRQs: %d)\n",
> +	pr_info("registered BCM7038 L1 intc (mem: 0x%px, IRQs: %d)\n",
>  		intc->cpus[0]->map_base, IRQS_PER_WORD * intc->n_words);
>  
>  	return 0;
> diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
> index 983640eba418..1cc4dd1d584a 100644
> --- a/drivers/irqchip/irq-bcm7120-l2.c
> +++ b/drivers/irqchip/irq-bcm7120-l2.c
> @@ -318,7 +318,7 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn,
>  		}
>  	}
>  
> -	pr_info("registered %s intc (mem: 0x%p, parent IRQ(s): %d)\n",
> +	pr_info("registered %s intc (mem: 0x%px, parent IRQ(s): %d)\n",
>  			intc_name, data->map_base[0], data->num_parent_irqs);
>  
>  	return 0;
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
> index 691d20eb0bec..6760edeeb666 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -262,7 +262,7 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
>  		ct->chip.irq_set_wake = irq_gc_set_wake;
>  	}
>  
> -	pr_info("registered L2 intc (mem: 0x%p, parent irq: %d)\n",
> +	pr_info("registered L2 intc (mem: 0x%px, parent irq: %d)\n",
>  			base, parent_irq);
>  
>  	return 0;
> 

Why is that something useful to do? This just tells you where the device
is mapped in the VA space, and I doubt that's a useful information,
hashed pointers or not. Am I missing something obvious?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...