linux-kernel - Re: [PATCH 7/7] platform/x86: fujitsu-laptop: Clean up constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180211213534.GD1124@kmp-mobile.hq.kempniu.pl>
Date:   Sun, 11 Feb 2018 22:35:34 +0100
From:   Michał Kępień <kernel@...pniu.pl>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Jonathan Woithe <jwoithe@...t42.net>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] platform/x86: fujitsu-laptop: Clean up constants

> Hi,
> 
> It looks like this driver needs to #include <linux/bitops.h>
> for use of BIT() macros.
> 
> See Documentation/process/submit-checklist.rst:
> 1) If you use a facility then #include the file that defines/declares
>    that facility.  Don't depend on other header files pulling in ones
>    that you use.
> 
> Some $ARCH may work without it while another one may not.

Noted, thanks!

-- 
Best regards,
Michał Kępień