linux-kernel - Re: [PATCH 3.16 002/136] staging: lustre: ptlrpc: kfree used instead of kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.21.1802112134500.21780@casper.infradead.org>
Date:   Sun, 11 Feb 2018 21:35:48 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Ben Hutchings <ben@...adent.org.uk>
cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        akpm@...ux-foundation.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Oleg Drokin <oleg.drokin@...el.com>,
        Peng Tao <bergwolf@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nadav Amit <namit@...are.com>
Subject: Re: [PATCH 3.16 002/136] staging: lustre: ptlrpc: kfree used instead
 of kvfree


> 3.16.54-rc1 review patch.  If anyone has any objections, please let me know.

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> ------------------
> 
> From: Nadav Amit <namit@...are.com>
> 
> commit c3eec59659cf25916647d2178c541302bb4822ad upstream.
> 
> rq_reqbuf is allocated using kvmalloc() but released in one occasion
> using kfree() instead of kvfree().
> 
> The issue was found using grep based on a similar bug.
> 
> Fixes: d7e09d0397e8 ("add Lustre file system client support")
> Fixes: ee0ec1946ec2 ("lustre: ptlrpc: Replace uses of OBD_{ALLOC,FREE}_LARGE")
> 
> Cc: Peng Tao <bergwolf@...il.com>
> Cc: Oleg Drokin <oleg.drokin@...el.com>
> Cc: James Simmons <jsimmons@...radead.org>
> 
> Signed-off-by: Nadav Amit <namit@...are.com>
> Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> [bwh: Backported to 3.16: use OBD_FREE_LARGE()]
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/staging/lustre/lustre/ptlrpc/sec.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/sec.c
> @@ -867,7 +867,7 @@ void sptlrpc_request_out_callback(struct
>  	if (req->rq_pool || !req->rq_reqbuf)
>  		return;
>  
> -	OBD_FREE(req->rq_reqbuf, req->rq_reqbuf_len);
> +	OBD_FREE_LARGE(req->rq_reqbuf, req->rq_reqbuf_len);
>  	req->rq_reqbuf = NULL;
>  	req->rq_reqbuf_len = 0;
>  }
> 
>