linux-kernel - Re: [PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5ho9kuad8k.wl-tiwai@suse.de>
Date:   Mon, 12 Feb 2018 08:17:15 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Ulf Magnusson" <ulfalizer@...il.com>
Cc:     "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        <alsa-devel@...a-project.org>, <will.deacon@....com>,
        "Tony Lindgren" <tony@...mide.com>, <tfiga@...omium.org>,
        <sboyd@...eaurora.org>, "Nicholas Piggin" <npiggin@...il.com>,
        <broonie@...nel.org>, <robh@...nel.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        <linux-riscv@...ts.infradead.org>, <hch@....de>,
        <mina86@...a86.com>, <paul.burton@...s.com>, <paulus@...abs.org>,
        <perex@...ex.cz>,
        "Hans-Christian Noren Egtvedt" <egtvedt@...fundet.no>,
        "Marek Szyprowski" <m.szyprowski@...sung.com>,
        "Albert Ou" <albert@...ive.com>,
        "Palmer Dabbelt" <palmer@...ive.com>,
        "Masahiro Yamada" <yamada.masahiro@...ionext.com>,
        <vgupta@...opsys.com>, <mgorman@...hsingularity.net>,
        "Linux Kbuild mailing list" <linux-kbuild@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97

On Fri, 09 Feb 2018 00:20:21 +0100,
Ulf Magnusson wrote:
> 
> On Fri, Feb 09, 2018 at 12:15:36AM +0100, Ulf Magnusson wrote:
> > The AC97_BUS_NEW Kconfig symbol selects the globally undefined symbol
> > AC97.
> > 
> > Robert Jarzmik confirmed in https://lkml.org/lkml/2018/2/7/96 that the
> > select was put in by mistake and can be safely removed, with no other
> > changes required. Remove it.
> > 
> > Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> > ---
> >  sound/ac97/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/sound/ac97/Kconfig b/sound/ac97/Kconfig
> > index f8a64e15e5bf..baa5f8ef89d2 100644
> > --- a/sound/ac97/Kconfig
> > +++ b/sound/ac97/Kconfig
> > @@ -5,7 +5,6 @@
> >  
> >  config AC97_BUS_NEW
> >  	tristate
> > -	select AC97
> >  	help
> >  	  This is the new AC97 bus type, successor of AC97_BUS. The ported
> >  	  drivers which benefit from the AC97 automatic probing should "select"
> > -- 
> > 2.14.1
> > 
> 
> I didn't have a particular tree in mind for this patchset by the way.
> Feel free to take the patch in wherever it makes sense.

Applied now, thanks.


Takashi