linux-kernel - Re: linux-next: manual merge of the tip tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180212071905.tjsu56rvru7smss4@gmail.com>
Date:   Mon, 12 Feb 2018 08:19:05 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KarimAllah Ahmed <karahmed@...zon.de>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: linux-next: manual merge of the tip tree with Linus' tree

* Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> Today's linux-next merge of the tip tree got a conflict in:
> 
>   arch/x86/kvm/vmx.c
> 
> between commit:
> 
>   c992384bde84 ("KVM: vmx: speed up MSR bitmap merge")
> 
> from Linus' tree and commit:
> 
>   ff37dc0cd96c ("KVM/nVMX: Set the CPU_BASED_USE_MSR_BITMAPS if we have a valid L02 MSR bitmap")
> 
> from the tip tree.
> 
> I fixed it up (I think - see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 
> diff --cc arch/x86/kvm/vmx.c
> index f427723dc7db,91e3539cba02..000000000000
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@@ -10136,7 -10127,12 +10136,10 @@@ static void nested_get_vmcs12_pages(str
>   			(unsigned long)(vmcs12->posted_intr_desc_addr &
>   			(PAGE_SIZE - 1)));
>   	}
> - 	if (!nested_vmx_prepare_msr_bitmap(vcpu, vmcs12))
>  -	if (cpu_has_vmx_msr_bitmap() &&
>  -	    nested_cpu_has(vmcs12, CPU_BASED_USE_MSR_BITMAPS) &&
>  -	    nested_vmx_merge_msr_bitmap(vcpu, vmcs12))
> ++	if (nested_vmx_prepare_msr_bitmap(vcpu, vmcs12))
> + 		vmcs_set_bits(CPU_BASED_VM_EXEC_CONTROL,
> + 			      CPU_BASED_USE_MSR_BITMAPS);
> + 	else
>   		vmcs_clear_bits(CPU_BASED_VM_EXEC_CONTROL,
>   				CPU_BASED_USE_MSR_BITMAPS);
>   }
>
> @@@ -10224,14 -10220,9 +10227,14 @@@ static inline bool nested_vmx_prepare_m
>   	 *    updated to reflect this when L1 (or its L2s) actually write to
>   	 *    the MSR.
>   	 */
> - 	bool pred_cmd = msr_write_intercepted_l01(vcpu, MSR_IA32_PRED_CMD);
> - 	bool spec_ctrl = msr_write_intercepted_l01(vcpu, MSR_IA32_SPEC_CTRL);
> + 	bool pred_cmd = !msr_write_intercepted_l01(vcpu, MSR_IA32_PRED_CMD);
> + 	bool spec_ctrl = !msr_write_intercepted_l01(vcpu, MSR_IA32_SPEC_CTRL);
>   
>  +	/* Nothing to do if the MSR bitmap is not in use.  */
>  +	if (!cpu_has_vmx_msr_bitmap() ||
>  +	    !nested_cpu_has(vmcs12, CPU_BASED_USE_MSR_BITMAPS))
>  +		return false;
>  +
>   	if (!nested_cpu_has_virt_x2apic_mode(vmcs12) &&
>   	    !pred_cmd && !spec_ctrl)
>   		return false;

The resolution looks good to me, I did a similar resolution and diffed the 
linux-next version to the tip:msater version.

Thanks,

	Ingo