linux-kernel - Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180212174312.GN12979@localhost.localdomain>
Date:   Mon, 12 Feb 2018 18:43:12 +0100
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        vincent.guittot@...aro.org, luca.abeni@...tannapisa.it,
        claudio@...dence.eu.com, tommaso.cucinotta@...tannapisa.it,
        bristot@...hat.com, mathieu.poirier@...aro.org, tkjos@...roid.com,
        joelaf@...gle.com, morten.rasmussen@....com,
        dietmar.eggemann@....com, patrick.bellasi@....com,
        alessio.balsini@....com
Subject: Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl_bandwidth

On 12/02/18 12:34, Steven Rostedt wrote:
> On Mon, 12 Feb 2018 14:40:28 +0100
> Juri Lelli <juri.lelli@...hat.com> wrote:
> 
> > + *  - dl_bw (< 100%) is the bandwidth of the system (domain) on each CPU;
> > + *  - dl_total_bw array contains the currently allocated bandwidth on the
> > + *    i-eth CPU.
> 
> The comment for dl_total_bw doesn't make sense. You mean that
> dl_total_bw is the cpu's bandwidth? If so, let's not call it total,
> because that would suggest it's the bandwidth of all CPUs. What about
> dl_cpu_bw?

Huh, I meant to properly fix this (broken already in mainline) comment,
but I only managed to do that (hopefully) in next patch. :/

However, this surely needs to be fixed here. It's tracking the sum of
all tasks' (across CPUs) bandwidth admitted on the system, so that's why
it's called dl_total_bw. Incremented when a task passes sched_setattr()
and decremented when it leaves the system or changes scheduling class.

Does it make a bit more sense? Would you still prefer a different name?

Thanks,

- Juri