linux-kernel - Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180212130239.506cbce9@gandalf.local.home>
Date:   Mon, 12 Feb 2018 13:02:39 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Juri Lelli <juri.lelli@...hat.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        vincent.guittot@...aro.org, luca.abeni@...tannapisa.it,
        claudio@...dence.eu.com, tommaso.cucinotta@...tannapisa.it,
        bristot@...hat.com, mathieu.poirier@...aro.org, tkjos@...roid.com,
        joelaf@...gle.com, morten.rasmussen@....com,
        dietmar.eggemann@....com, patrick.bellasi@....com,
        alessio.balsini@....com
Subject: Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl_bandwidth

On Mon, 12 Feb 2018 18:43:12 +0100
Juri Lelli <juri.lelli@...hat.com> wrote:

> However, this surely needs to be fixed here. It's tracking the sum of
> all tasks' (across CPUs) bandwidth admitted on the system, so that's why
> it's called dl_total_bw. Incremented when a task passes sched_setattr()
> and decremented when it leaves the system or changes scheduling class.
> 
> Does it make a bit more sense? Would you still prefer a different name?

No the name is fine, the comment needs to change.

 - dl_total_bw - tracks the sum of all tasks' bandwidth across CPUs.

How's that?

-- Steve