linux-kernel - Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180212181731.GO12979@localhost.localdomain>
Date:   Mon, 12 Feb 2018 19:17:31 +0100
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        vincent.guittot@...aro.org, luca.abeni@...tannapisa.it,
        claudio@...dence.eu.com, tommaso.cucinotta@...tannapisa.it,
        bristot@...hat.com, mathieu.poirier@...aro.org, tkjos@...roid.com,
        joelaf@...gle.com, morten.rasmussen@....com,
        dietmar.eggemann@....com, patrick.bellasi@....com,
        alessio.balsini@....com
Subject: Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl_bandwidth

On 12/02/18 13:02, Steven Rostedt wrote:
> On Mon, 12 Feb 2018 18:43:12 +0100
> Juri Lelli <juri.lelli@...hat.com> wrote:
> 
> > However, this surely needs to be fixed here. It's tracking the sum of
> > all tasks' (across CPUs) bandwidth admitted on the system, so that's why
> > it's called dl_total_bw. Incremented when a task passes sched_setattr()
> > and decremented when it leaves the system or changes scheduling class.
> > 
> > Does it make a bit more sense? Would you still prefer a different name?
> 
> No the name is fine, the comment needs to change.
> 
>  - dl_total_bw - tracks the sum of all tasks' bandwidth across CPUs.
> 
> How's that?

LGTM. I'll fix in next version.

Thanks!

- Juri