linux-kernel - Re: [PATCH] x86/entry/64: Remove unused icebp macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180213073621.shvpk6l4fgwxc34g@gmail.com>
Date:   Tue, 13 Feb 2018 08:36:21 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     x86-ml <x86@...nel.org>, linux-tip-commits@...r.kernel.org,
        linux-kernel@...r.kernel.org, dvlasenk@...hat.com, luto@...nel.org,
        torvalds@...ux-foundation.org, jpoimboe@...hat.com, hpa@...or.com,
        brgerst@...il.com, linux@...inikbrodowski.net,
        peterz@...radead.org, tglx@...utronix.de
Subject: Re: [PATCH] x86/entry/64: Remove unused icebp macro


* Borislav Petkov <bp@...en8.de> wrote:

> On Mon, Feb 12, 2018 at 02:18:55AM -0800, tip-bot for Dominik Brodowski wrote:
> > Commit-ID:  5a10e729bc0aa9420a23a70b169eadd229c27bc1
> > Gitweb:     https://git.kernel.org/tip/5a10e729bc0aa9420a23a70b169eadd229c27bc1
> > Author:     Dominik Brodowski <linux@...inikbrodowski.net>
> > AuthorDate: Sun, 11 Feb 2018 11:49:48 +0100
> > Committer:  Ingo Molnar <mingo@...nel.org>
> > CommitDate: Mon, 12 Feb 2018 08:06:37 +0100
> > 
> > x86/entry/64: Indent PUSH_AND_CLEAR_REGS and POP_REGS properly
> 
> Ontop:
> 
> ---
> From: Borislav Petkov <bp@...e.de>
> 
> That macro was touched around 2.5.8 times, judging by the full history
> linux repo, but it was unused even then. Get rid of it already.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  arch/x86/entry/calling.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 6985440c68fa..dce7092ab24a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -159,10 +159,6 @@ For 32-bit we have the following conventions - kernel is built with
>  	.if \pop_rdi
>  	popq %rdi
>  	.endif
> -	.endm
> -
> -	.macro icebp
> -	.byte 0xf1
>  .endm

Good find!

I applied this separately, and added your SOB: let me know if that's not OK.

Thanks,

	Ingo