linux-kernel - Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518513744.25655.8.camel@nxp.com>
Date:   Tue, 13 Feb 2018 09:22:24 +0000
From:   Cosmin Samoila <cosmin.samoila@....com>
To:     "broonie@...nel.org" <broonie@...nel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "wakasugi.jb@...asahi-kasei.co.jp" <wakasugi.jb@...asahi-kasei.co.jp>,
        "mihai.serban@...il.com" <mihai.serban@...il.com>,
        "S.j. Wang" <shengjiu.wang@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "mihai.serban@....com" <mihai.serban@....com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

Hi Mark,

> > 
> > +static int ak4458_hw_params(struct snd_pcm_substream *substream,
> > +			    struct snd_pcm_hw_params *params,
> > +			    struct snd_soc_dai *dai)
> > +{
> > +	struct snd_soc_codec *codec = dai->codec;
> > +	struct ak4458_priv *ak4458 =
> > snd_soc_codec_get_drvdata(codec);
> > +	u8 format;
> > +	int pcm_width = max(params_physical_width(params), ak4458-
> > >slot_width);
> > +
> > +#ifdef AK4458_ACKS_USE_MANUAL_MODE
> > +	u8 dfs1, dfs2;
> > +#endif
> What's this and why is it a compile time option?

This is used to set the codec in Manual Setting Mode, meaning that
the default sampling speed is set based on DFS0 and DFS1 bits. In
Auto Setting Mode, the MCLK frequency is detected automatically and
DFS bits are ignored.
This compile time option is used to know when to set the ACKS bit in
init_reg function that switches between modes.
At this moment we are only using Auto Mode and I can remove it if
you think is not necessary.

Thank you,
Cosmin