linux-kernel - Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Feb 2018 11:55:37 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Cosmin Samoila <cosmin.samoila@....com>
Cc:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "wakasugi.jb@...asahi-kasei.co.jp" <wakasugi.jb@...asahi-kasei.co.jp>,
        "mihai.serban@...il.com" <mihai.serban@...il.com>,
        "S.j. Wang" <shengjiu.wang@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "mihai.serban@....com" <mihai.serban@....com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

On Tue, Feb 13, 2018 at 09:22:24AM +0000, Cosmin Samoila wrote:

> This is used to set the codec in Manual Setting Mode, meaning that
> the default sampling speed is set based on DFS0 and DFS1 bits. In
> Auto Setting Mode, the MCLK frequency is detected automatically and
> DFS bits are ignored.

But why is it a compile time option?

> This compile time option is used to know when to set the ACKS bit in
> init_reg function that switches between modes.
> At this moment we are only using Auto Mode and I can remove it if
> you think is not necessary.

Yes, just remove it - if there needs to be some control it should
probably be done by the machine driver, or through DT.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)