linux-kernel - Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518529671.3592.9.camel@suse.de>
Date:   Tue, 13 Feb 2018 14:47:51 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Matias Bjørling <mb@...htnvm.io>, hch@....de,
        keith.busch@...el.com
Cc:     javier@...xlabs.com, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote:
> +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> +			    u8 log_page, void *log,
> +			    size_t size, size_t offset)
> +{
> +	struct nvme_command c = { };
> +	unsigned long dwlen = (size / 4) - 1;

Consulting my long gone maths knowledge suggests the parantheses aren't
really needed here.

-- 
Johannes Thumshirn                                          Storage
jthu
mshirn@...e.de                                +49 911 74053 689
SUSE
LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane
Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38
9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850