linux-kernel - Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3b14909-0f9a-b0b3-876e-eb9722b528d1@lightnvm.io>
Date:   Tue, 13 Feb 2018 14:53:01 +0100
From:   Matias Bjørling <mb@...htnvm.io>
To:     Johannes Thumshirn <jthumshirn@...e.de>, hch@....de,
        keith.busch@...el.com
Cc:     javier@...xlabs.com, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

On 02/13/2018 02:47 PM, Johannes Thumshirn wrote:
> On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote:
>> +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>> +			    u8 log_page, void *log,
>> +			    size_t size, size_t offset)
>> +{
>> +	struct nvme_command c = { };
>> +	unsigned long dwlen = (size / 4) - 1;
> 
> Consulting my long gone maths knowledge suggests the parantheses aren't
> really needed here.
> 

Heh, you're right. However, it does make it a bit more readable? The 
untrained eye would properly mess it up was my thinking for keeping them.