linux-kernel - Re: [PATCH] mm/gup: Fixed coding style error and warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1518550368.22190.53.camel@perches.com>
Date:   Tue, 13 Feb 2018 11:32:48 -0800
From:   Joe Perches <joe@...ches.com>
To:     Mario Leinweber <marioleinweber@....de>, akpm@...ux-foundation.org
Cc:     mingo@...nel.org, kirill.shutemov@...ux.intel.com,
        aneesh.kumar@...ux.vnet.ibm.com, mhocko@...e.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/gup: Fixed coding style error and warnings.

You should have a changelog.

On Tue, 2018-02-13 at 14:17 -0500, Mario Leinweber wrote:
[]
> diff --git a/mm/gup.c b/mm/gup.c
[]
> @@ -1635,7 +1640,7 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
>  					 PMD_SHIFT, next, write, pages, nr))
>  				return 0;
>  		} else if (!gup_pte_range(pmd, addr, next, write, pages, nr))
> -				return 0;
> +			return 0;

And of all these changes, this might be the only really useful one
as the
indentation is misleading.