linux-kernel - Re: [PATCH] mm/gup: Fixed coding style error and warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180213193649.GA2663@bombadil.infradead.org>
Date:   Tue, 13 Feb 2018 11:36:49 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Mario Leinweber <marioleinweber@....de>
Cc:     akpm@...ux-foundation.org, mingo@...nel.org,
        kirill.shutemov@...ux.intel.com, aneesh.kumar@...ux.vnet.ibm.com,
        mhocko@...e.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/gup: Fixed coding style error and warnings.

On Tue, Feb 13, 2018 at 02:17:22PM -0500, Mario Leinweber wrote:
>  	if (flags & FOLL_SPLIT && PageTransCompound(page)) {
>  		int ret;
> +
>  		get_page(page);

Hi Mario,

Thanks for your patch, but this kind of change to the Linux core is not
generally welcomed.  There are a lot of people working on the core and
having whitespace changes conflict with real changes isn't a good use of
people's time.  You can practice whitespace changes in drivers/staging
before graduating to patches which change functionality.

Hope to see you back soon!