linux-kernel - Re: [PATCH 9/9] x86/mm: Adjust virtual address space layout in early boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180214122652.pzcmiakssichuhn5@gmail.com>
Date:   Wed, 14 Feb 2018 13:26:52 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andy Lutomirski <luto@...capital.net>,
        Borislav Petkov <bp@...e.de>, Andi Kleen <ak@...ux.intel.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] x86/mm: Adjust virtual address space layout in early
 boot


* Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> wrote:

> On Wed, Feb 14, 2018 at 12:10:49PM +0000, Ingo Molnar wrote:
> > 
> > * Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> wrote:
> > 
> > > We need to adjust virtual address space to support switching between
> > > paging modes.
> > > 
> > > The adjustment happens in __startup_64().
> > > 
> > > We also have to change KASLR code that doesn't expect variable
> > > VMALLOC_SIZE_TB.
> > > 
> > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > > ---
> > >  arch/x86/boot/compressed/kaslr.c        | 14 ++++++++--
> > >  arch/x86/include/asm/page_64_types.h    |  9 ++----
> > >  arch/x86/include/asm/pgtable_64_types.h | 25 +++++++++--------
> > >  arch/x86/kernel/head64.c                | 49 +++++++++++++++++++++++++++------
> > >  arch/x86/kernel/head_64.S               |  2 +-
> > >  arch/x86/mm/dump_pagetables.c           |  3 ++
> > >  arch/x86/mm/kaslr.c                     | 11 ++++----
> > >  7 files changed, 77 insertions(+), 36 deletions(-)
> > 
> > This is too large and risky - would it be possible to split this up into multiple, 
> > smaller patches?
> 
> Let me check what I can do here.
> 
> If you are fine with previous patches please apply. I will send split up
> of this patch separately.

Yes, the first 8 patches are looking good and I have already applied them locally, 
will push them out after testing.

Thanks,

	Ingo