linux-kernel - Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9098c6c8-83e5-5e1f-519b-68e14738c24a@acm.org>
Date:   Wed, 14 Feb 2018 15:46:31 -0600
From:   Corey Minyard <minyard@....org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org,
        Haiyue Wang <haiyue.wang@...ux.intel.com>
Subject: Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in
 kcs_bmc_handle_data

On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.

Thanks, queued for next release.

-corey

> Addresses-Coverity-ID: 1465255 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
> This code was compiled with GCC 7.3.0
>
>   drivers/char/ipmi/kcs_bmc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c
> index 3a3498a..6476bfb 100644
> --- a/drivers/char/ipmi/kcs_bmc.c
> +++ b/drivers/char/ipmi/kcs_bmc.c
> @@ -95,6 +95,7 @@ static void kcs_bmc_handle_data(struct kcs_bmc *kcs_bmc)
>   	switch (kcs_bmc->phase) {
>   	case KCS_PHASE_WRITE_START:
>   		kcs_bmc->phase = KCS_PHASE_WRITE_DATA;
> +		/* fall through */
>   
>   	case KCS_PHASE_WRITE_DATA:
>   		if (kcs_bmc->data_in_idx < KCS_MSG_BUFSIZ) {