linux-kernel - Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b0b8c09-340b-19a8-f1ac-c9e02803e88f@enneenne.com>
Date:   Thu, 15 Feb 2018 16:33:46 +0100
From:   Rodolfo Giometti <giometti@...eenne.com>
To:     Lukas Senger <lukas@...dolin.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

On 15/02/18 16:08, Lukas Senger wrote:
>>> @@ -20,18 +21,20 @@
>>>    		target = <&gpio>;
>>>    		__overlay__ {
>>>    			pps_pins: pps_pins@12 {
>>> -				brcm,pins =     <18>;
>>> -				brcm,function = <0>;    // in
>>> -				brcm,pull =     <0>;    // off
>>> +				brcm,pins =     <18 17>;
>>> +				brcm,function = <0 1>;    // in
>>> out
>>> +				brcm,pull =     <0 0>;    // off
>>> off
>>
>> These modifications are not PPS related.
>>
>>>    			};
>>>    		};
>>>    	};
>>>    
>>>    	__overrides__ {
>>> -		gpiopin = <&pps>,"gpios:4",
>>> +		gpiopin = <&pps>,"in-gpios:4",
>>>    			  <&pps>,"reg:0",
>>>    			  <&pps_pins>,"brcm,pins:0",
>>>    			  <&pps_pins>,"reg:0";
>>> +		echopin = <&pps>,"out-gpios:4",
>>> +			  <&pps_pins>,"brcm,pins:4";
>>
>> Ditto.
> 
> I don't understand why these modifications are unrelated. Especially
> the echopin-option should exist, shouldn't it?

These modifications are needed to define a custom instance of a PPS device which 
is not part of the PPS subtree, that's why they should be put into another patch.

Ciao,

Rodolfo

-- 

HCE Engineering                      e-mail: giometti@...-engineering.it
GNU/Linux Solutions                          giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it