linux-kernel - Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9b965fe-fee2-3aab-0f2c-681d2835070c@enneenne.com>
Date:   Thu, 15 Feb 2018 16:36:25 +0100
From:   Rodolfo Giometti <giometti@...eenne.com>
To:     Lukas Senger <lukas@...dolin.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

On 15/02/18 16:12, Lukas Senger wrote:
> 
>> Why a void function? You should use it to toggle echoing GPIO... =8-o
> 
> RFC 2783 says to generate the echo pulse "as rapidly as possible" which
> is why I do the toggling in the irq handler. However this leaves the
> default echo function installed which just floods syslog.

The pps_event() function does it for you in a beauty-and-clear way by using the 
info.echo() function. :-D

> Another problem with this patch is that it also is against my old one
> and not against current kernel code.

Yes, correct it please.

Ciao,

Rodolfo

-- 

HCE Engineering                      e-mail: giometti@...-engineering.it
GNU/Linux Solutions                          giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it