linux-kernel - Re: [PATCH] objtool/x86: Replace Non-standard Range Expression in Case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180216150356.qnxkr3jopfmt3o5q@treble>
Date:   Fri, 16 Feb 2018 09:03:56 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Progyan Bhattacharya <bprogyan@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Nick Desaulniers <nick.desaulniers@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Nicholas Mc Guire <der.herr@...r.at>
Subject: Re: [PATCH] objtool/x86: Replace Non-standard Range Expression in
 Case

On Fri, Feb 16, 2018 at 08:09:24PM +0530, Progyan Bhattacharya wrote:
> Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3
> Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.
> 
> While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
> error: range expressions in switch statements are non-standard [-Werror=pedantic]
> 
> Signed-off-by: Progyan Bhattacharya <progyanb@....org>

Progyan,

Please try to be respectful of reviewers' time by

  a) running scripts/checkpatch.pl and closely reviewing your patch
     before sending;

  b) not sending multiple revisions in a single day;

  c) when sending a new revision, add the version number in the subject
     line and clarify what has changed.


I'd also recommend reviewing the following resources:

  - https://www.youtube.com/watch?v=-3HNeoFuSH0

  - Documentation/process/submitting-patches.rst

-- 
Josh