linux-kernel - Re: [PATCH 1/3] x86/Kconfig : Add missing i586-class cpus to X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP8WD_YMVJBx7qpqsLW8PSwkc5HS1GXTMJgWPHbSdnTt4fYCOw@mail.gmail.com>
Date:   Fri, 16 Feb 2018 10:08:20 -0500
From:   tedheadster <tedheadster@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] x86/Kconfig : Add missing i586-class cpus to
 X86_CMPXCHG64 Kconfig group

Andy

On Fri, Feb 16, 2018 at 9:17 AM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Feb 15, 2018 at 6:54 PM, Matthew Whitehead
> <tedheadster@...il.com> wrote:
>> Several i586-class cpus supporting this instruction are missing from
>> the X86_CMPXCHG64 config group.
>
> What about Intel Quark? MinuteIA core which is currently set as M586TSC.
>

I am unsure what you are asking here. I do not see any option for
Intel Quark processor types in arch/x86/Kconfig.cpu. Are you saying
there should be one?

Or perhaps you are saying that Intel Quark is currently set for
M586TSC and it lacks the CMPXCHG64 instruction? If so, I would change
my config option from M586TSC to M586.

>> Using a configuration with either M586TSC or M586MMX currently sets
>> X86_MINIMUM_CPU_FAMILY=4 instead of the correct value 5.
>
> Are you sure about this? See above.
>

Yes I am sure of this, I tested it very well. A similar problem
happens with an M686 configuration for a different reason.

- Matthew