linux-kernel - Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ve7Q2FDvLeN2PjbHsobvxckKq8L7YJddUWvfOVTWmvEqw@mail.gmail.com>
Date:   Sun, 18 Feb 2018 16:16:06 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed
 memory allocation in sata_dwc_port_start()

On Sun, Feb 18, 2018 at 3:22 PM, Tejun Heo <tj@...nel.org> wrote:
> On Fri, Feb 16, 2018 at 11:39:13AM +0200, Andy Shevchenko wrote:
>> On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
>> > From: Markus Elfring <elfring@...rs.sourceforge.net>
>> > Date: Thu, 15 Feb 2018 22:15:25 +0100
>> >
>> > Omit an extra message for a memory allocation failure in this
>> > function.
>> >
>> > This issue was detected by using the Coccinelle software.
>>
>> Tejun, it's up to you. In case you are fine with the change,
>
> Yeah, these are marginal at best and one may be able to argue that
> emitting a message with device identifier is still useful but these
> allocations are order-zero and can't fail to begin with, so...

IIRC device core prints a warn with error code and device name if
->probe() fails.

-- 
With Best Regards,
Andy Shevchenko