linux-kernel - Re: [PATCH] mm: don't defer struct page initialization for Xen pv guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 00:25:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Juergen Gross <jgross@...e.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, xen-devel@...ts.xenproject.org,
        akpm@...ux-foundation.org, mhocko@...e.com,
        Juergen Gross <jgross@...e.com>, stable@...r.kernel.org
Subject: Re: [PATCH] mm: don't defer struct page initialization for Xen pv
 guests

Hi Juergen,

I love your patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.16-rc1 next-20180216]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Juergen-Gross/mm-don-t-defer-struct-page-initialization-for-Xen-pv-guests/20180218-233657
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-randconfig-x017-201807 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   mm/page_alloc.c: In function 'update_defer_init':
>> mm/page_alloc.c:352:6: error: implicit declaration of function 'xen_pv_domain'; did you mean 'del_dma_domain'? [-Werror=implicit-function-declaration]
     if (xen_pv_domain())
         ^~~~~~~~~~~~~
         del_dma_domain
   cc1: some warnings being treated as errors

vim +352 mm/page_alloc.c

   339	
   340	/*
   341	 * Returns false when the remaining initialisation should be deferred until
   342	 * later in the boot cycle when it can be parallelised.
   343	 */
   344	static inline bool update_defer_init(pg_data_t *pgdat,
   345					unsigned long pfn, unsigned long zone_end,
   346					unsigned long *nr_initialised)
   347	{
   348		/* Always populate low zones for address-constrained allocations */
   349		if (zone_end < pgdat_end_pfn(pgdat))
   350			return true;
   351		/* Xen PV domains need page structures early */
 > 352		if (xen_pv_domain())
   353			return true;
   354		(*nr_initialised)++;
   355		if ((*nr_initialised > pgdat->static_init_pgcnt) &&
   356		    (pfn & (PAGES_PER_SECTION - 1)) == 0) {
   357			pgdat->first_deferred_pfn = pfn;
   358			return false;
   359		}
   360	
   361		return true;
   362	}
   363	#else
   364	static inline void reset_deferred_meminit(pg_data_t *pgdat)
   365	{
   366	}
   367	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27454 bytes)