linux-kernel - Re: [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1519049704.3408.17.camel@pengutronix.de>
Date:   Mon, 19 Feb 2018 15:15:04 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Tobias Jordan <Tobias.Jordan@...ktrobit.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     sil2review@...ts.osadl.org
Subject: Re: [PATCH] gpu: ipu-v3: prg: fix device node leak in
 ipu_prg_lookup_by_phandle

Hi Tobias,

On Thu, 2018-02-15 at 15:35 +0100, Tobias Jordan wrote:
> Before returning, call of_node_put() for the device node returned by
> of_parse_phandle().
> 
> Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket")
> Signed-off-by: Tobias Jordan <Tobias.Jordan@...ktrobit.com>
> ---
>  drivers/gpu/ipu-v3/ipu-prg.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
> index 067365c733c6..97b99500153d 100644
> --- a/drivers/gpu/ipu-v3/ipu-prg.c
> +++ b/drivers/gpu/ipu-v3/ipu-prg.c
> @@ -102,11 +102,14 @@ ipu_prg_lookup_by_phandle(struct device *dev, const char *name, int ipu_id)
>  			mutex_unlock(&ipu_prg_list_mutex);
>  			device_link_add(dev, prg->dev, DL_FLAG_AUTOREMOVE);
>  			prg->id = ipu_id;
> +			of_node_put(prg_node);
>  			return prg;
>  		}
>  	}
>  	mutex_unlock(&ipu_prg_list_mutex);
>  
> +	of_node_put(prg_node);
> +
>  	return NULL;
>  }
>  

Applied both to imx-drm/next, thank you.

regards
Philipp