linux-kernel - Re: [PATCH] gpu: ipu-v3: make const arrays int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 15:15:28 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Colin King <colin.king@...onical.com>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: ipu-v3: make const arrays int_reg static, shrinks
 object size

Hi Colin,

On Wed, 2018-02-14 at 18:45 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const read-only arrays int_reg on the stack but instead
> make them static. Makes the object code smaller by over 80 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   28024	   8936	    192	  37152	   9120	drivers/gpu/ipu-v3/ipu-common.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   27794	   9080	    192	  37066	   90ca	drivers/gpu/ipu-v3/ipu-common.o
> 
> (gcc version 7.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/gpu/ipu-v3/ipu-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index 658fa2d3e40c..48685cddbad1 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -1089,7 +1089,7 @@ static void ipu_irq_handler(struct irq_desc *desc)
>  {
>  	struct ipu_soc *ipu = irq_desc_get_handler_data(desc);
>  	struct irq_chip *chip = irq_desc_get_chip(desc);
> -	const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14};
> +	static const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14};
>  
>  	chained_irq_enter(chip, desc);
>  
> @@ -1102,7 +1102,7 @@ static void ipu_err_irq_handler(struct irq_desc *desc)
>  {
>  	struct ipu_soc *ipu = irq_desc_get_handler_data(desc);
>  	struct irq_chip *chip = irq_desc_get_chip(desc);
> -	const int int_reg[] = { 4, 5, 8, 9};
> +	static const int int_reg[] = { 4, 5, 8, 9};
>  
>  	chained_irq_enter(chip, desc);

Applied to imx-drm/next, thank you.

regards
Philipp