linux-kernel - Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7a53542-3098-9932-ef92-92f16b39dc91@linux-m68k.org>
Date:   Mon, 19 Feb 2018 12:47:09 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Finn Thain <fthain@...egraphics.com.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies

Hi Finn,

On 19/02/18 12:39, Finn Thain wrote:
> The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and
> have no need for 8390.o. modinfo confirms no dependency on 8390.ko.
> Drop the redundant dependency from the Makefile. objdump confirms
> that this patch has no effect on the module binaries.
> 
> The superfluous additions of 8390.o were introduced in
> commit 644570b83026 ("8390: Move the 8390 related drivers").
> 
> Cc: Greg Ungerer <gerg@...ux-m68k.org>

Looks right for mcf8390.c.

Acked-by: Greg Ungerer <gerg@...ux-m68k.org>

Regards
Greg


> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/net/ethernet/8390/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/8390/Makefile b/drivers/net/ethernet/8390/Makefile
> index f975c2fc88a3..1d650e66cc6e 100644
> --- a/drivers/net/ethernet/8390/Makefile
> +++ b/drivers/net/ethernet/8390/Makefile
> @@ -7,8 +7,8 @@ obj-$(CONFIG_MAC8390) += mac8390.o
>  obj-$(CONFIG_APNE) += apne.o 8390.o
>  obj-$(CONFIG_ARM_ETHERH) += etherh.o
>  obj-$(CONFIG_AX88796) += ax88796.o
> -obj-$(CONFIG_HYDRA) += hydra.o 8390.o
> -obj-$(CONFIG_MCF8390) += mcf8390.o 8390.o
> +obj-$(CONFIG_HYDRA) += hydra.o
> +obj-$(CONFIG_MCF8390) += mcf8390.o
>  obj-$(CONFIG_NE2000) += ne.o 8390p.o
>  obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o
>  obj-$(CONFIG_PCMCIA_AXNET) += axnet_cs.o 8390.o
> @@ -16,4 +16,4 @@ obj-$(CONFIG_PCMCIA_PCNET) += pcnet_cs.o 8390.o
>  obj-$(CONFIG_STNIC) += stnic.o 8390.o
>  obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o
>  obj-$(CONFIG_WD80x3) += wd.o 8390.o
> -obj-$(CONFIG_ZORRO8390) += zorro8390.o 8390.o
> +obj-$(CONFIG_ZORRO8390) += zorro8390.o
>