linux-kernel - Re: [PATCH net 2/4] net/8390: Fix msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180219.141137.2095980245673495027.davem@davemloft.net>
Date:   Mon, 19 Feb 2018 14:11:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     fthain@...egraphics.com.au
Cc:     netdev@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu

From: Finn Thain <fthain@...egraphics.com.au>
Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST)

> The lib8390 module parameter 'msg_enable' doesn't do anything useful:
> it causes an ancient version string to be logged.

Since you are removing the last reference to this 'version' string
you should remove it as well.

I'm surprised the compiler doesn't warn about this.