linux-kernel - Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zi4428l7.fsf@suse.com>
Date:   Mon, 19 Feb 2018 18:27:32 +0100
From:   Aurélien Aptel <aaptel@...e.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Steve French <sfrench@...ba.org>
Cc:     linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech_release

"Gustavo A. R. Silva" <gustavo@...eddedor.com> writes:
> It seems this is a copy-paste error and that the proper variable to use
> in this particular case is _sha512_ instead of _md5_.

*sigh* I re-read this a lot yet still missed it. Minor memory leak
 fixed, good coverity catch and thanks for the fix!

Reviewed-by: Aurelien Aptel <aaptel@...e.com>

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)