linux-kernel - Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3eb514ff-d659-80ef-3e09-aa39c829f862@embeddedor.com>
Date:   Mon, 19 Feb 2018 12:13:54 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Aurélien Aptel <aaptel@...e.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Steve French <sfrench@...ba.org>
Cc:     linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech_release

Hi Aurélien,

On 02/19/2018 11:27 AM, Aurélien Aptel wrote:
> "Gustavo A. R. Silva" <gustavo@...eddedor.com> writes:
>> It seems this is a copy-paste error and that the proper variable to use
>> in this particular case is _sha512_ instead of _md5_.
> 
> *sigh* I re-read this a lot yet still missed it. Minor memory leak
>   fixed, good coverity catch and thanks for the fix!
> 
> Reviewed-by: Aurelien Aptel <aaptel@...e.com>
> 

Glad to help. Thanks for the review.

BTW I think this should be sent to stable too.
--
Gustavo