linux-kernel - [tip:x86/pti] x86/LDT: Avoid warning in 32-bit builds with older gcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-f2f18b16c779978ece4a04f304a92ff9ac8fbce5@git.kernel.org>
Date:   Tue, 20 Feb 2018 02:27:37 -0800
From:   tip-bot for Jan Beulich <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     brgerst@...il.com, torvalds@...ux-foundation.org,
        dvlasenk@...hat.com, JBeulich@...e.com, tglx@...utronix.de,
        peterz@...radead.org, mingo@...nel.org, jpoimboe@...hat.com,
        linux-kernel@...r.kernel.org, jbeulich@...e.com, bp@...en8.de,
        luto@...nel.org, hpa@...or.com
Subject: [tip:x86/pti] x86/LDT: Avoid warning in 32-bit builds with older
 gcc

Commit-ID:  f2f18b16c779978ece4a04f304a92ff9ac8fbce5
Gitweb:     https://git.kernel.org/tip/f2f18b16c779978ece4a04f304a92ff9ac8fbce5
Author:     Jan Beulich <JBeulich@...e.com>
AuthorDate: Mon, 19 Feb 2018 07:52:10 -0700
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 20 Feb 2018 09:33:40 +0100

x86/LDT: Avoid warning in 32-bit builds with older gcc

BUG() doesn't always imply "no return", and hence should be followed by
a return statement even if that's obviously (to a human) unreachable.

Signed-off-by: Jan Beulich <jbeulich@...e.com>
Acked-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Brian Gerst <brgerst@...il.com>
Cc: Denys Vlasenko <dvlasenk@...hat.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/5A8AF2AA02000078001A91E9@prv-mh.provo.novell.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/include/asm/mmu_context.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h
index c931b88..1de72ce 100644
--- a/arch/x86/include/asm/mmu_context.h
+++ b/arch/x86/include/asm/mmu_context.h
@@ -74,6 +74,7 @@ static inline void *ldt_slot_va(int slot)
 	return (void *)(LDT_BASE_ADDR + LDT_SLOT_STRIDE * slot);
 #else
 	BUG();
+	return (void *)fix_to_virt(FIX_HOLE);
 #endif
 }