linux-kernel - Re: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Feb 2018 19:50:35 -0500
From:   "J . Bruce Fields" <bfields@...ldses.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Jeff Layton <jlayton@...nel.org>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        linux-nfs@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static

Thanks, applying.--b.

On Wed, Feb 07, 2018 at 10:29:47AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and
> do not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> fs/lockd/svc.c:60:10: warning: symbol 'nlm_ntf_refcnt' was not declared.
> Should it be static?
> fs/lockd/svc.c:61:1: warning: symbol 'nlm_ntf_wq' was not declared.
> Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/lockd/svc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 9c36d614bf89..346ed161756d 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -57,8 +57,8 @@ static struct task_struct	*nlmsvc_task;
>  static struct svc_rqst		*nlmsvc_rqst;
>  unsigned long			nlmsvc_timeout;
>  
> -atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
> -DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
> +static atomic_t nlm_ntf_refcnt = ATOMIC_INIT(0);
> +static DECLARE_WAIT_QUEUE_HEAD(nlm_ntf_wq);
>  
>  unsigned int lockd_net_id;
>  
> -- 
> 2.15.1