linux-kernel - Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfEc0a_Fff1znWVos3rPzCGsvGLGX7NgH_bH96egree7A@mail.gmail.com>
Date:   Thu, 22 Feb 2018 19:33:44 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sebastian Panceac <sebastian@...in.io>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        x86@...nel.org
Subject: Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot

On Thu, Feb 22, 2018 at 11:27 AM, Sebastian Panceac <sebastian@...in.io> wrote:
>
> When powering Intel Edison module with 3.3V, the "reboot" command makes the module stuck.
> If the module is powered at a greater voltage, like 4.4V(as the Edison Mini Breakout board does), reboot works OK.
> This patch fixes the reboot problem for Intel Edison powered at 3.3V.

Unfortunately it doesn't explain the root cause. OTOH it seems no one
has any means to find it, no documentation, no person responsible for
Edison firmware responsive.

At least what I would like to mention that this copies a behaviour of
official BSP for Edison, where RESET command applied by default (and
BOOT is enforced by user via kernel command line).

Perhaps someone can dig an internet to see what BOOT SCU command means.

Your patch is mangled. Can you use `git send-email` directly?

> Signed-off-by: Sebastian Panceac <sebastian@...in.io>
> ---
> arch/x86/platform/intel-mid/intel-mid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/intel-mid/intel-mid.c b/arch/x86/platform/intel-mid/intel-mid.c
> index 12a2725..d2b2e9f 100644
> --- a/arch/x86/platform/intel-mid/intel-mid.c
> +++ b/arch/x86/platform/intel-mid/intel-mid.c
> @@ -79,7 +79,7 @@ static void intel_mid_power_off(void)
>
> static void intel_mid_reboot(void)
> {
> - intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0);
> + intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0);
> }
>
> static unsigned long __init intel_mid_calibrate_tsc(void)
> --
> 2.7.4




-- 
With Best Regards,
Andy Shevchenko