linux-kernel - Re: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALdTtnv12uzaVQLzEMOgPdN6wqo=UAdm+_nhDhcf5Jr2zY=4hA@mail.gmail.com>
Date:   Thu, 22 Feb 2018 11:02:38 -0700
From:   dann frazier <dann.frazier@...onical.com>
To:     George Cherian <gcherian@...iumnetworks.com>
Cc:     George Cherian <george.cherian@...ium.com>,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        wsa@...-dreams.de, Dmitry Bazhenov <dmitry.bazhenov@...iga.com>
Subject: Re: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK

On Tue, Jan 30, 2018 at 7:28 AM, George Cherian
<gcherian@...iumnetworks.com> wrote:
> Gentle Ping on this series.

I've been using these on a few Cavium Sabre boards, which previously
had an unusable system interface (/dev/ipmi) due to timeouts or just
enumerations failures. So, fwiw:

Tested-by: dann frazier <dann.frazier@...onical.com>

 -dann

> On 01/18/2018 11:09 AM, George Cherian wrote:
>>
>> From: Dmitry Bazhenov <dmitry.bazhenov@...iga.com>
>>
>> Fix the driver violation of the common practice to return
>> ENXIO error on a slave address NACK.
>>
>> Signed-off-by: Dmitry Bazhenov <dmitry.bazhenov@...iga.com>
>> Signed-off-by: George Cherian <george.cherian@...ium.com>
>> ---
>>   drivers/i2c/busses/i2c-xlp9xx.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-xlp9xx.c
>> b/drivers/i2c/busses/i2c-xlp9xx.c
>> index b970bf8..6d78cdc 100644
>> --- a/drivers/i2c/busses/i2c-xlp9xx.c
>> +++ b/drivers/i2c/busses/i2c-xlp9xx.c
>> @@ -324,7 +324,8 @@ static int xlp9xx_i2c_xfer_msg(struct xlp9xx_i2c_dev
>> *priv, struct i2c_msg *msg,
>>                 dev_dbg(priv->dev, "transfer error %x!\n", priv->msg_err);
>>                 if (priv->msg_err & XLP9XX_I2C_INTEN_BUSERR)
>>                         xlp9xx_i2c_init(priv);
>> -               return -EIO;
>> +               return (priv->msg_err & XLP9XX_I2C_INTEN_NACKADDR) ?
>> +                       -ENXIO : -EIO;
>>         }
>>         if (timeleft == 0) {
>>
>
> Regards
> -George