linux-kernel - Re: [PATCH 09/12] usb: roles: Add Intel XHCI USB role switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a5d758f-643d-7159-162d-50f053d99c17@redhat.com>
Date:   Sun, 25 Feb 2018 13:11:38 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 09/12] usb: roles: Add Intel XHCI USB role switch driver

Hi,

On 16-02-18 14:38, Heikki Krogerus wrote:
> On Fri, Feb 16, 2018 at 11:47:48AM +0100, Hans de Goede wrote:
>> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
>> index 060643a1b5c8..7d1b8c82b208 100644
>> --- a/drivers/usb/Makefile
>> +++ b/drivers/usb/Makefile
>> @@ -65,3 +65,5 @@ obj-$(CONFIG_USB_COMMON)	+= common/
>>   obj-$(CONFIG_USBIP_CORE)	+= usbip/
>>   
>>   obj-$(CONFIG_TYPEC)		+= typec/
>> +
>> +obj-$(CONFIG_USB_ROLE_SWITCH)	+= roles/
>> diff --git a/drivers/usb/roles/Kconfig b/drivers/usb/roles/Kconfig
>> new file mode 100644
>> index 000000000000..e5c2bfaf8ba5
>> --- /dev/null
>> +++ b/drivers/usb/roles/Kconfig
>> @@ -0,0 +1,14 @@
>> +if USB_ROLE_SWITCH
>> +
>> +config USB_ROLES_INTEL_XHCI
>> +	tristate "Intel XHCI USB Role Switch"
>> +	depends on ACPI && X86 && EXTCON
> 
> Hold on... There is no dependency on extcon, or is there?

You are right, this is an old leftover, removed for v2
of this patchset which I'm preparing atm.

Regards,

Hans