linux-kernel - Re: [PATCH 03/12] usb: typec: API for controlling USB Type-C Multiplexers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2790a56-4dc8-5668-8e24-41e27e796197@redhat.com>
Date:   Sun, 25 Feb 2018 13:13:38 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        USB <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 03/12] usb: typec: API for controlling USB Type-C
 Multiplexers

Hi,

On 16-02-18 15:00, Andy Shevchenko wrote:
> On Fri, Feb 16, 2018 at 12:47 PM, Hans de Goede <hdegoede@...hat.com> wrote:
>> USB Type-C connectors consist of various muxes and switches
>> that route the pins on the connector to the right locations.
>> The USB Type-C drivers need to be able to control the muxes,
>> as they are the ones that know things like the cable plug
>> orientation, and the current mode that was negotiated with
>> the partner.
>>
>> This introduces a small API for registering and controlling
>> cable plug orientation switches, and separate small API for
>> registering and controlling pin multiplexer/demultiplexer
>> switches that are needed with Accessory/Alternate Modes.
> 
>> +       sw = __device_find_connection(dev, "typec-switch", NULL,
>> +                                     typec_switch_match);
> 
> Perhaps one line? (even if it takes ~83 characters)

I'm not a fan of breaking the 80 chars limit when we can
reasonably cleanly split a statement (such as here), so I'm
keeping this as is for v2.

Regards,

Hans