linux-kernel - Re: [PATCH 04/12] usb: common: Small class for USB role switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 25 Feb 2018 13:16:26 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 04/12] usb: common: Small class for USB role switches

Hi,

On 16-02-18 19:33, Randy Dunlap wrote:
> On 02/16/2018 02:47 AM, Hans de Goede wrote:
>> From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>>
> 
>> diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
>> new file mode 100644
>> index 000000000000..923e3721d183
>> --- /dev/null
>> +++ b/drivers/usb/common/roles.c
>> @@ -0,0 +1,305 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/**
> 
> Just use /* since this is not kernel-doc notation.

Thank you for catching this, fixed for v2.

Regards,

Hans


> 
>> + * USB Role Switch Support
>> + *
>> + * Copyright (C) 2018 Intel Corporation
>> + * Author: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>> + *         Hans de Goede <hdegoede@...hat.com>
>> + */
> 
>