linux-kernel - Re: [PATCH v2 2/2] pci: endpoint: Fix kernel panic after put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcYas_2i8r1G1J=DXnwmor_4tbWm0GZtP_VorVMK1vKpw@mail.gmail.com>
Date:   Mon, 26 Feb 2018 21:12:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Rolf Evers-Fischer <embedded24@...rs-fischer.de>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rolf Evers-Fischer <rolf.evers.fischer@...iv.com>
Subject: Re: [PATCH v2 2/2] pci: endpoint: Fix kernel panic after put_device()

On Mon, Feb 26, 2018 at 7:16 PM, Rolf Evers-Fischer
<embedded24@...rs-fischer.de> wrote:
> From: Rolf Evers-Fischer <rolf.evers.fischer@...iv.com>
>
> 'put_device()' calls the relase function 'pci_epf_dev_release()',
> which already frees 'epf->name' and 'epf'.
>
> Therefore we must not free them again after 'put_device()'.

>  put_dev:
>         put_device(dev);
> -       kfree(epf->name);
> +       return ERR_PTR(ret);

Ouch, if it's double free (sounds like it is) it should be fixed up to
initial commit which brought that.
Thus, Fixes tag would be good to see.

-- 
With Best Regards,
Andy Shevchenko