linux-kernel - Re: [PATCH 1/2] PCI: add vendor id for Altera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1519746127.25526.25.camel@suse.de>
Date:   Tue, 27 Feb 2018 16:42:07 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Michael Moese <mmoese@...e.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Eli Billauer <eli.billauer@...il.com>,
        Anatolij Gustschin <agust@...x.de>
Subject: Re: [PATCH 1/2] PCI: add vendor id for Altera

On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn <jthumshirn@...e.de>
> wrote:
> > 
> > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > definitions from xillybus_pcie.c and altera-cvp.c.
> 
> > 
> >  #include <linux/pci.h>
> > +#include <linux/pci_ids.h>
> 
> > 
> >  #include <linux/pci.h>
> > +#include <linux/pci_ids.h>
> 
> Isn't pci.h includes pci_ids.h ?

It indeed is, but it won't do any harm and it's not quite clear what the
general policy (regarding pci_ids.h) is, some drivers include it (even in
the drivers/pci/) some don't.

Bjorn, any guidance from your side?

Byte,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshi
rn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH,
Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham
Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600
D0D0 0393 969D 2D76 0850