linux-kernel - Re: [PATCH 1/2] PCI: add vendor id for Altera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180227173929.GA127842@bhelgaas-glaptop.roam.corp.google.com>
Date:   Tue, 27 Feb 2018 11:39:29 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Michael Moese <mmoese@...e.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Eli Billauer <eli.billauer@...il.com>,
        Anatolij Gustschin <agust@...x.de>
Subject: Re: [PATCH 1/2] PCI: add vendor id for Altera

On Tue, Feb 27, 2018 at 04:42:07PM +0100, Johannes Thumshirn wrote:
> On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> > On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn <jthumshirn@...e.de>
> > wrote:
> > > 
> > > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > > definitions from xillybus_pcie.c and altera-cvp.c.
> > 
> > > 
> > >  #include <linux/pci.h>
> > > +#include <linux/pci_ids.h>
> > 
> > > 
> > >  #include <linux/pci.h>
> > > +#include <linux/pci_ids.h>
> > 
> > Isn't pci.h includes pci_ids.h ?
> 
> It indeed is, but it won't do any harm and it's not quite clear what the
> general policy (regarding pci_ids.h) is, some drivers include it (even in
> the drivers/pci/) some don't.
> 
> Bjorn, any guidance from your side?

I don't think it's necessary to add the include.

Please cc: linux-pci@...r.kernel.org in addition, since that feeds the
patchwork I work from.