linux-kernel - RE: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7bb6d4240f04d7ba5b1f07a1087ee64@ausx13mpc124.AMER.DELL.COM>
Date:   Tue, 27 Feb 2018 16:15:04 +0000
From:   <Mario.Limonciello@...l.com>
To:     <andy.shevchenko@...il.com>
CC:     <dvhart@...radead.org>, <pali.rohar@...il.com>,
        <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>
Subject: RE: [PATCH 1/3] platform/x86: dell-smbios: Correct some style
 warnings

> -----Original Message-----
> From: platform-driver-x86-owner@...r.kernel.org [mailto:platform-driver-x86-
> owner@...r.kernel.org] On Behalf Of Andy Shevchenko
> Sent: Tuesday, February 27, 2018 10:04 AM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: Darren Hart <dvhart@...radead.org>; Pali Rohár <pali.rohar@...il.com>;
> LKML <linux-kernel@...r.kernel.org>; Platform Driver <platform-driver-
> x86@...r.kernel.org>
> Subject: Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings
> 
> On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello
> <mario.limonciello@...l.com> wrote:
> 
> >         /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
> > -          6 bytes of entry */
> > +        * 6 bytes of entry
> > +        */
> 
> I would prefer not to mix with net style, since you are fixing this, perhaps
> 
> /*
>  * 4 ...
>  * 6 ...
>  */
> 
> ?
> 
Thanks, will adjust again when I resubmit with changes for 3/3.