linux-kernel - Re: [PATCH 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VchPrF8ndHck9pzjOOScTS627x9TFLsnr+LWxiwTgck9w@mail.gmail.com>
Date:   Tue, 27 Feb 2018 18:16:46 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mario Limonciello <Mario.Limonciello@...l.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 3/3] platform/x86: dell-smbios: Link all dell-smbios-*
 modules together

On Tue, Feb 27, 2018 at 6:13 PM,  <Mario.Limonciello@...l.com> wrote:

>> > --- a/drivers/platform/x86/dell-smbios.h
>> > +++ b/drivers/platform/x86/dell-smbios.h
>> > @@ -75,4 +75,10 @@ int dell_laptop_register_notifier(struct notifier_block
>> *nb);
>> >  int dell_laptop_unregister_notifier(struct notifier_block *nb);
>> >  void dell_laptop_call_notifier(unsigned long action, void *data);
>> >
>> > +/* for the supported backends */
>> > +int init_dell_smbios_wmi(void);
>> > +void exit_dell_smbios_wmi(void);
>> > +int init_dell_smbios_smm(void);
>> > +void exit_dell_smbios_smm(void);
>> > +
>>
>> ...here...
>
> So do you mean you would rather see inline functions in header
> file for the #else case then?

At least is sounds as a standard practice to me.

-- 
With Best Regards,
Andy Shevchenko