linux-kernel - Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180227201355.GA27525@1wt.eu>
Date:   Tue, 27 Feb 2018 21:13:55 +0100
From:   Willy Tarreau <w@....eu>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     geert@...ux-m68k.org, andy.shevchenko@...il.com,
        rabel@...ertabel.eu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of
 x/y commands

On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote:
> The current version is not parsing multiple x/y commands as the code
> originally intended. On top of that, kstrtoul() expects
> NULL-terminated strings. Finally, the code had to do two passes over
> the string, while now only one is done.
> 
> Some explanations about the supported syntax are added as well.

Thanks Miguel for doing this. To be fair, I personally think that the code
was significantly complexified compared to the original version, just for
the purpose of using one library function designed to multiply by ten and
add a number. Not to mention that it now requires a copy before parsing.
For me it simply means that the initial code change was a wrong idea in
the end. But at least with your version, the bugs introduced by the
previous "fix" should now be gone, which is a good thing.

Thanks,
Willy