linux-kernel - Re: [PATCH] sparse doesn't support indirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a85a7cf-c59c-f338-2087-c9de799adbe8@infradead.org>
Date:   Tue, 27 Feb 2018 12:18:30 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Matthew Wilcox <willy@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparse doesn't support indirect_branch attribute

On 02/27/2018 11:48 AM, Matthew Wilcox wrote:
> 
> Don't use __attribute__((indirect_branch)) if we're compiling with
> sparse.
> 
> Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index e2c7f4369eff..b6be4cc25e9d 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -93,7 +93,7 @@
>  #define __weak		__attribute__((weak))
>  #define __alias(symbol)	__attribute__((alias(#symbol)))
>  
> -#ifdef RETPOLINE
> +#if defined(RETPOLINE) && !defined(__CHECKER__)
>  #define __noretpoline __attribute__((indirect_branch("keep")))
>  #endif
>  
> 

I don't mind the patch, but I did send a patch for this attribute on Feb. 13, 2018,
to the sparse mailing list.

-- 
~Randy