linux-kernel - [PATCH v3 1/1] x86: Fix Intel Edison module stuck reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 11:40:49 +0200
From:   Sebastian Panceac <sebastian@...in.io>
To:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        linux-kernel@...r.kernel.org, andy.shevchenko@...il.com,
        x86@...nel.org
Cc:     Sebastian Panceac <sebastian@...in.io>
Subject: [PATCH v3 1/1] x86: Fix Intel Edison module stuck reboot

When powering Intel Edison module with 3.3V, the "reboot" command makes
the module stuck.
If the module is powered at a greater voltage, like 4.4V (as the Edison
Mini Breakout board does), reboot works OK.

This patch copies the behaviour from the official Intel Edison BSP,
where "IPCMSG_COLD_RESET" message was sent to SCU by default at
reboot time.

In the official BSP, sending the "IPCMSG_COLD_BOOT" message instead of
"IPCMSG_COLD_RESET" was possible, by using a kernel command
line parameter.

Signed-off-by: Sebastian Panceac <sebastian@...in.io>
---

Hi,

I submitted again the patch, after taking into consideration Andy's suggestions.

Regards!

 arch/x86/platform/intel-mid/intel-mid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/intel-mid/intel-mid.c b/arch/x86/platform/intel-mid/intel-mid.c
index 2c67bae..fb1df94 100644
--- a/arch/x86/platform/intel-mid/intel-mid.c
+++ b/arch/x86/platform/intel-mid/intel-mid.c
@@ -79,7 +79,7 @@ static void intel_mid_power_off(void)

 static void intel_mid_reboot(void)
 {
-	intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0);
+	intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0);
 }

 static unsigned long __init intel_mid_calibrate_tsc(void)
-- 
2.7.4